netty: Fix receipt of ClosedChannelException instead of actual error.… - #2255
Merged
Conversation
…ixes grpc#1330. Our API allows pings to be send even after the transport has been shutdown. We currently don't handle the case, where the Netty channel has been closed but the NettyClientHandler has not yet been removed from the pipeline, correctly. That is, we need to query the shutdown status whenever we receive a ClosedChannelException. Also, some cleanup.
| finalPing.failed(future.cause()); | ||
| Throwable cause = future.cause(); | ||
| if (cause instanceof ClosedChannelException) { | ||
| cause = lifecycleManager.getShutdownThrowable(); |
Member
There was a problem hiding this comment.
What if getShutdownThrowable() is null?
Contributor
Author
There was a problem hiding this comment.
Then null is propagated to the PingCallback. The API spec seems to allow it. If our code works correctly, we should never get a ClosedChannelException without the ClientTransportLifeCycleManager knowing about it, no?
Member
There was a problem hiding this comment.
I don't believe PingCallback was intended to allow a null cause. And such a null cause is very difficult to debug.
We should just create a status in that case, like done elsewhere, maybe with the message "Ping failed but for unknown reason".
Member
|
LGTM |
Contributor
Author
|
@ejona86 PTAL |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Fixes #1330.
Our API allows pings to be send even after the transport has been shutdown. We currently
don't handle the case, where the Netty channel has been closed but the NettyClientHandler
has not yet been removed from the pipeline, correctly. That is, we need to query the shutdown
status whenever we receive a ClosedChannelException.
Also, some cleanup.